Re: [PATCH] amd8111e endian & barrier fixes

[Andi Kleen]

Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> writes:

> Hi Jeff !
>
> This patch against the amd8111e makes it work on some about-to-be-released
> piece of PPC hardware. It does:
>
>  - Fix endian
>  - Search for the PHY on MII instead of hard coding the ID
>  - Add a couple of wmb's where needed on descriptor updates
>
> I must appologize for having re-indented one of the rx functions, but I
> just couldn't read/understand it without doing so, it was going back
> leftward in the middle of a { } block ...

It's basically impossible to review the patch properly because
of that change. Can you please separate the arbitary white space
change into a different patch? 

Also I would suggest you send the patch to the driver 
maintainers for review first (cc'ed) 

>From a quick look the change to clear the ring rx flags completely
instead of clearing the bit looks bogus. Why did you not just add a
endian conversion there?

I can test it when it's properly reviewd.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/