Re: kswapd in tight loop 2.6.9-rc3-bk-recent

From: Andrew Morton
Date: Fri Oct 08 2004 - 00:01:11 EST


Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
> - if (zone->free_pages <= zone->pages_high) {
> + if (zone->free_pages < zone->pages_high) {

This is too subtle. An open-coded test for non-zero ->present_pages is far
more readable and maintainable.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/