Re: 2.6.9-rc3-mm3

From: William Lee Irwin III
Date: Thu Oct 07 2004 - 17:18:25 EST


On 2004.10.07, William Lee Irwin III wrote:
>> Here is a more likely correct patch for what that was trying to do,
>> however misguided that may be. Untested, uncompiled, vs. 2.6.9-rc3-mm3
>> without the bad patch:
> ...
>>+static inline void profile_tick(int type, struct pt_regs *regs)
>>+{
>>+ extern cpumask_t prof_cpu_mask;
>>+

On Thu, Oct 07, 2004 at 09:25:41PM +0000, J.A. Magallon wrote:
> This conflicts with kernel/irq/proc.c:
> unsigned long prof_cpu_mask = -1;
> Shouldn't this be:
> cpumask_t prof_cpu_mask = CPU_MASK_NONE;
> This will show problems when NR_CPUS > sizeof(long)....
> Hope this helps.

What in the goddamned Hell? Who wrote that? What arch?


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/