Re: [PATCH] i386/gcc bug with do_test_wp_bit

From: Andi Kleen
Date: Wed Oct 06 2004 - 06:57:14 EST


On Tue, Oct 05, 2004 at 06:45:05PM -0700, Zachary Amsden wrote:
> Playing around with gcc 3.3.3, I compiled a 2.6 series kernel for i386
> and discovered it panics on boot. The problem was gcc 3.3.3 can inline
> functions even if declared after their call sites. This causes i386 to
> not boot, since do_test_wp_bit() must not exist in the __init section.
> Similar problems may exist in the boot code for other architectures, but
> I can't confirm that at this time. x86_64 is not affected.

That should have been fixed long ago by sorting the exception
table. I checked and the code is still there:

asmlinkage void __init start_kernel(void)
{
...
sort_main_extable();


Something must be rotten in your setup. I definitely don't see the
same problems with a unit-at-a-time 3.3 gcc.

Can you double check that the sort is really done?

The patch is imho not needed.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/