Re: [PATCH] 2.6 SGI Altix I/O code reorganization

From: Jesse Barnes
Date: Tue Oct 05 2004 - 10:50:35 EST


On Monday, October 4, 2004 10:13 pm, Luck, Tony wrote:
> I'm ok with the delete/add of most of the SGI
> specific files (maybe it still isn't perfect yet,
> but it may be close enough to take it, and then
> clean up with some small patches).
>
> But you seem to be touching some files outside of pure SGI
> stuff. These two are a bit of a concern:
>
> include/asm-ia64/io.h

Not sure about these changes...

> arch/ia64/pci/pci.c

It looks like the only non-codingstyle change here is to make pci_root_ops
non-static (and btw, some of the CodingStyle fixups look wrong). If it needs
to be non-static, it should be declared in a header file so we don't have to
extern it in sn_pci_fixup_bus.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/