Re: bug in sched.c:activate_task()

[Nick Piggin]

Chen, Kenneth W wrote:
> Update p->timestamp to "now" in activate_task() doesn't look right
> to me at all.  p->timestamp records last time it was running on a
> cpu.  activate_task shouldn't update that variable when it queues
> a task on the runqueue.
>
> This bug (and combined with others) triggers improper load balancing.
>
> Patch against linux-2.6.9-rc3.  Didn't diff it against 2.6.9-rc3-mm2
> because mm tree has so many change in sched.c.
>
> Signed-off-by: Ken Chen <kenneth.w.chen@xxxxxxxxx>

Actually, now that I have the code in front of me, I was wrong
and this patch is right.

This timestamp is never used for anything, so the assignment is
pointless.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/