Re: 2.6.9-rc3-mm2

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxx> wrote:

> Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > Must not put side-effects into a macro that is NOP on
> > !SMP.
> 
> This one, too:
> 
> -		per_cpu(ip_conntrack_stat, get_cpu()).count++;	\
> -		put_cpu();					\

btw., also remove or fix the get_cpu_ptr() definition in percpu.h, it's
buggy for the same reason, but fortunately unused.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/