Re: [PATCH] -mm swsusp: copy_page is harmfull

[Benjamin Herrenschmidt]

On Sat, 2004-09-25 at 10:27, Linux Kernel Mailing List wrote:
> ChangeSet 1.1983.1.3, 2004/09/24 17:27:41-07:00, akpm@xxxxxxxx
> 
> 	[PATCH] -mm swsusp: copy_page is harmfull
> 	
> 	From: Pavel Machek <pavel@xxxxxx>
> 	
> 	This is my fault from long time ago: copy_page can't be used for copying
> 	task struct, therefore we can't use it in swsusp.

Hi !

Just curious, but why ?

It would be useful to have this in platform code, I don't see why I couldn't
use copy_page() on ppc and I suspect it will be more efficient than memcpy
since it has specific optimisations due to the fact that we are known to be
fully aligned and the size of the copy is a constant aligned power of 2.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/