Re: [PATCH 1/2] detach_pid(): restore optimization

From: Kirill Korotaev
Date: Sat Oct 02 2004 - 08:07:59 EST


I can sign off both patches. They look ok.

Signed-off-By: Kirill Korotaev <dev@xxxxx>

Kirill's kernel/pid.c rework broke optimization logic in detach_pid().
Non zero return from __detach_pid() was used to indicate, that this pid
can probably be freed. Current version always (modulo idle threads)
return non zero value, thus resulting in unneccesary pid_hash scanning.

Also, uninlining __detach_pid() reduces pid.o text size from 2492 to 1600
bytes.

Oleg.

[...]

Kirill


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/