Re: 2.6.9-rc3-mm1 build failure

From: Ed Sweetman
Date: Sat Oct 02 2004 - 08:03:33 EST


Tim Cambrant wrote:

On Sat, Oct 02, 2004 at 12:50:38PM +0200, Adrian Bunk wrote:


On Sat, Oct 02, 2004 at 02:29:21AM -0700, Andrew Morton wrote:


Norbert Preining <preining@xxxxxxxx> wrote:


..
LD .tmp_vmlinux1
arch/i386/kernel/built-in.o(.text+0x111f5): In function `end_level_ioapic_irq':
: undefined reference to `irq_mis_count'
kernel/built-in.o(.text+0x1eba7): In function `ack_none':
: undefined reference to `ack_APIC_irq'
make[1]: *** [.tmp_vmlinux1] Fehler 1
make[1]: Leaving directory `/usr/src/linux-2.6.9-rc3-mm1'


hm, that's clever.

See if arch/i386/kernel/io_apic.c needs


s/io_apic.c/irq.c/ and it should solve Norberts problem.



#include <asm/io_apic.h>
...



Sorry, forgot to cc LKML. The following patch works for me.


--- linux-2.6.9-rc3-mm1/arch/i386/kernel/irq.c.orig 2004-10-02 12:52:57.833294096 +0200
+++ linux-2.6.9-rc3-mm1/arch/i386/kernel/irq.c 2004-10-02 12:53:14.935694136 +0200
@@ -17,6 +17,7 @@

#include <asm/uaccess.h>
#include <asm/hardirq.h>
+#include <asm/io_apic.h>

#ifdef CONFIG_4KSTACKS
/*




asm/io_apic.h is the file that seems to be missing all the declarations. When i included it in irq.c as the above patch does, my build immediately failed with this. My config is for uni-processor with io-apic enabled in config.

In file included from arch/i386/kernel/irq.c:20:
include/asm/io_apic.h: At top level:
include/asm/io_apic.h:108: error: `MAX_IO_APICS' undeclared here (not in a function)
include/asm/io_apic.h:154: error: `MAX_IO_APICS' undeclared here (not in a function)
include/asm/io_apic.h: In function `io_apic_read':
include/asm/io_apic.h:167: warning: implicit declaration of function `__fix_to_virt'
include/asm/io_apic.h:167: error: `FIX_IO_APIC_BASE_0' undeclared (first use in this function)
include/asm/io_apic.h:167: error: (Each undeclared identifier is reported only once
include/asm/io_apic.h:167: error: for each function it appears in.)
include/asm/io_apic.h: In function `io_apic_write':
include/asm/io_apic.h:173: error: `FIX_IO_APIC_BASE_0' undeclared (first use in this function)
include/asm/io_apic.h: In function `io_apic_modify':
include/asm/io_apic.h:187: error: `FIX_IO_APIC_BASE_0' undeclared (first use in this function)
make[1]: *** [arch/i386/kernel/irq.o] Error 1

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/