RE: [PATCH]: megaraid 2.20.4: Fixes a data corruption bug

[Bagalkote, Sreenivas]

James,

The submitted previous version of megaraid (2.20.3.1) had 
register_ioctl32_conversion & unregister_ioctl32_conversion 
defined to empty statements if CONFIG_COMPAT was _not_
defined.

But I think the preferred way was to have the occurances of 
(un)register_ioctl32_conversion in the code surrounded by 
#ifdef CONFIG_COMPAT ... #endif directly. In the kernel source
only register_ioctl32_conversion has these #ifdef .. #endif. The
unregister_ioctl32_conversion doesn't.

This patch should take care of that.

Thanks,
Sreenivas

---
diff -Naur linux-error/drivers/scsi/megaraid/megaraid_mm.c
linux-fixed/drivers/scsi/megaraid/megaraid_mm.c
--- linux-error/drivers/scsi/megaraid/megaraid_mm.c	2004-10-01
08:42:09.999572008 -0700
+++ linux-fixed/drivers/scsi/megaraid/megaraid_mm.c	2004-10-01
08:42:51.383280728 -0700
@@ -1151,7 +1151,9 @@
 	con_log(CL_DLEVEL1 , ("exiting common mod\n"));
 
 	unregister_chrdev(majorno, "megadev");
+#ifdef CONFIG_COMPAT
 	unregister_ioctl32_conversion(MEGAIOCCMD);
+#endif
 }
 
 module_init(mraid_mm_init);

---

>-----Original Message-----
>From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxx]
>Sent: Wednesday, September 29, 2004 11:16 PM
>To: Mukker, Atul
>Cc: Bagalkote, Sreenivas; 'linux-kernel@xxxxxxxxxxxxxxx';
>'linux-scsi@xxxxxxxxxxxxxxx'; 'bunk@xxxxxxxxx'; 'Andrew Morton';
>'Matt_Domsch@xxxxxxxx'
>Subject: RE: [PATCH]: megaraid 2.20.4: Fixes a data corruption bug
>
>
>On Wed, 2004-09-29 at 17:28, Mukker, Atul wrote:
>> Considering the criticality of this fix, we hope it make 
>into the 2.6.9
>> release candidate as soon as possible. Can you update us 
>with your views on
>> this.
>
>The attached patch is mangled by the emailer...do you have a pristine
>version?
>
>James
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/