Re: [Ext2-devel] [Patch 6/10]: ext3 online resize: remove on-stack bogus inode

[Matthew Wilcox]

On Thu, Sep 30, 2004 at 02:23:45PM +0100, Stephen Tweedie wrote:
> Remove the "bogus" on-stack inode.  It's only used as a marker for
> indirectly passing the sb to various functions, so also add
> ext3_journal_start_sb() which starts a transaction for a given
> super_block rather than for an inode.
> 
> --- linux-2.6.9-rc2-mm4/fs/ext3/resize.c.=K0005=.orig
> +++ linux-2.6.9-rc2-mm4/fs/ext3/resize.c
> @@ -159,7 +159,7 @@ static void mark_bitmap_end(int start_bi
>   *
>   * We only pass inode because of the ext3 journal wrappers.
>   */

Should probably update the comment too ;-)

(who was it said inline documentation gets updated when the code does?  ;-P)

> @@ -616,7 +616,7 @@ exit_free:
>   *
>   * We only pass inode because of the ext3 journal wrappers.
>   */

Same here.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/