Re: [PATCH] sata_svw: Fix __iomem related warnings
From: Jeff Garzik
Date: Mon Sep 13 2004 - 08:22:06 EST
Christoph Hellwig wrote:
On Mon, Sep 13, 2004 at 02:27:22PM +1000, Benjamin Herrenschmidt wrote:
This patch adds some (ugly) casts to sata_svw to remove the
warnings generated by the new iomem stuff.
Umm, maybe it's just me - but shouldn't you fix them properly?
- writeb(tf->ctl, ioaddr->ctl_addr);
+ writeb(tf->ctl, (void __iomem *)ioaddr->ctl_addr);
e.g. ioaddr->ctl_addr should get a __iomem attribute
Wrong. Read the code.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/