Re: [PATCH 1/3] copyfile: generic_sendpage

From: Andrew Morton
Date: Sat Sep 04 2004 - 17:42:00 EST


Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> o Add sendfile() support for file targets to normal mm/filemap.c.

This comes up fairly regularly. See, for example,
http://lwn.net/Articles/88751/ for what appears to be a much simpler
implementation.

I discussed file->file sendfile with Linus a while back and he said

> I think it was about doing a 2GB file-file sendfile, and see your system
> grind to a halt without being able to kill it.
>
> That said, we have some of the same problems with just regular read/write
> too. sendfile just makes it easier.
>
> We should probably make read/write be interruptible by _fatal_ signals.
> It would require a new task state, though (TASK_KILLABLE or something, and
> it would show up as a normal 'D' state).

I don't know how much of a problem this is in practice - there are all
sorts of nasty things which unprivileged apps can do to the system by
overloading filesystems. Although most of them can be killed off by the
sysadmin.

(My infamous bash-shared-mappings stresstest can spend ten or more minutes
within a single write() call, but you have to try hard to do this).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/