Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27

From: Jeff Garzik
Date: Mon Aug 30 2004 - 12:38:42 EST


Denis Vlasenko wrote:
On Monday 30 August 2004 10:28, Peter Holik wrote:

static void set_rx_mode(struct net_device *dev)
{
spinlock_t *lp = &((struct netdev_private *)dev->priv)->lock;
unsigned long flags;
spin_lock_irqsave(lp, flags);
__set_rx_mode(dev);
- spin_unlock_irqrestore(&lp, flags);
+ spin_unlock_irqrestore(lp, flags);
}


Oh... it was my change which was buggy... Thanks for the fix!

Jeff, 2.6 most probably has the same bug.


Upstream 2.6 already has the fix...

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/