Re: Latest Altix I/O code reorganization code

From: Christoph Hellwig
Date: Fri Aug 27 2004 - 10:42:36 EST


On Fri, Aug 27, 2004 at 10:10:01AM -0500, Patrick Gefre wrote:
> io_init.c iomv.c Makefile pci pci_dma.c pci_extension.c
>
> arch/ia64/sn/ioif/pci:
> Makefile pcibr_ate.c pcibr_dma.c pcibr_provider.c pcibr_reg.c xtalk_providers.c
>

So why are pci_dma.c and pci_extensions.c not under pci? You probably should
just kill that pci subdir, too when there's just two other files left. Or
move those two to kernel/ and have a pci/ subdir which seems to fit other
ports quite well. But I'd rather see the functional changes first and then
do renaming of unchanged files last anyway so you changed get actually
reviewable. The current patchkit is not.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/