Re: [PATCH] kallsyms data size reduction / lookup speedup

[Randy.Dunlap]

On Wed, 25 Aug 2004 22:51:13 +0200 Sam Ravnborg wrote:

| On Wed, Aug 25, 2004 at 05:04:46AM +0100, pmarques@xxxxxxxxxxxx wrote:
| > 
| > This patch is an improvement over my first kallsyms speedup patch posted about 2
| > weeks ago.
| 
| My origianl comment still hold.
| Decoupling the compression and decompression part is not good.
| Better keep them close to each other.
| 
| Why not put all symbols in an __init section, compress them during kernel boot
| and then the original section get discarded.
| 
| After a quick browse of the code.
| - Use spaces around '=' etc.

I just want to emphasize Sam's last comment.  Find and use that
'spacebar' thingy a lot more.  Make the code human-readable, not
just machine-readable.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/