Re: [PATCH] Writeback page range hint

From: wli
Date: Mon Aug 23 2004 - 20:44:06 EST


On Tue, Aug 24, 2004 at 02:07:23AM +0100, Dave Jones wrote:
> Causes sparse spew..
> include/linux/writeback.h:54:19: warning: dubious one-bit signed bitfield
> include/linux/writeback.h:55:30: warning: dubious one-bit signed bitfield
> include/linux/writeback.h:56:19: warning: dubious one-bit signed bitfield
> include/linux/writeback.h:57:19: warning: dubious one-bit signed bitfield

Does this help?


Index: mm4-2.6.8.1/include/linux/writeback.h
===================================================================
--- mm4-2.6.8.1.orig/include/linux/writeback.h 2004-08-23 16:11:10.318739856 -0700
+++ mm4-2.6.8.1/include/linux/writeback.h 2004-08-23 18:26:45.790960088 -0700
@@ -51,10 +51,10 @@
loff_t start;
loff_t end;

- int nonblocking:1; /* Don't get stuck on request queues */
- int encountered_congestion:1; /* An output: a queue is full */
- int for_kupdate:1; /* A kupdate writeback */
- int for_reclaim:1; /* Invoked from the page allocator */
+ unsigned nonblocking:1, /* Don't get stuck on request queues */
+ encountered_congestion:1, /* An output: a queue is full */
+ for_kupdate:1, /* A kupdate writeback */
+ for_reclaim:1; /* Invoked from the page allocator */
};

/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/