Re: [patch] lazy TSS's I/O bitmap copy ...

[Linus Torvalds]

On Mon, 23 Aug 2004, Davide Libenzi wrote:
> 
> The eventually double GPF would happen only on TSS-IObmp-lazy tasks, ie 
> tasks using the I/O bitmap.

You could also check for the error code (at least the low 16 bits) being 
0, I guess, just to cut down the noise.

>	 The check for the I/O opcode can certainly be 
> done though, even if it'd make the code a little bit more complex.

Have to be very careful there to avoid nasty security issues. And with
ins/outs, you can have various prefixes etc, so decoding is not as trivial
as it could otherwise be. Even the regular in/out can have a data size
overrides..

in/out is also commonly used from vm86 mode, so decoding it really needs
to get all of the segmentation base crap right too. Nasty nasty nasty. 

In short, I think that if we do this at all, I'd much rather just do the
simple "trap twice" thing that Davide did. It's too easy to get it wrong
otherwise.

Or we should make this careful decoder some generic x86 function. We're
doing user instruction decoding in a number of places already, although I 
don't know how careful they generally need to be. Sadly, I really think 
that this one needs to be one of the most careful cases due to the vm86 
usage.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/