Re: [PATCH][2/7] xattr consolidation - LSM hook changes

From: Stephen Smalley
Date: Mon Aug 23 2004 - 15:24:27 EST


On Mon, 2004-08-23 at 15:03, Christoph Hellwig wrote:
> On Mon, Aug 23, 2004 at 02:16:17PM -0400, James Morris wrote:
> > This patch replaces the dentry parameter with an inode in the LSM
> > inode_{set|get|list}security hooks, in keeping with the ext2/ext3 code.
> > dentries are not needed here.
>
> Given that the actual methods take a dentry this sounds like a bad design.
> Can;t you just pass down the dentry through all of the ext2 interfaces?

Changing the methods to take an inode would be even better, IMHO, as the
dentry is unnecessary. That would simplify SELinux as well.

--
Stephen Smalley <sds@xxxxxxxxxxxxxx>
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/