Re: [PATCH] [broken?] Add MSI support to e1000

From: Roland Dreier
Date: Mon Aug 23 2004 - 12:38:50 EST


Tom> I do not see anything wrong with the patch and the kernel MSI
Tom> support because it works for a short time. Ganesh may provide
Tom> an answer on the MSI support in e1000 hardware.

Based on the e1000 documentation I have, the only thing required for
the e1000 to use MSI is to set the MSI enable bit in the PCI header.
Of course there may be some e1000 erratum involving MSI but I have not
been able to find any indication that this is the case.

It seems possible that there could be some problem in the core Linux
interrupt code even though some interrupts work -- for example there
could be a race condition triggered when a second interrupt is
delivered while handling the first interrupt. However I couldn't find
any such bug, although I am not at all an expert about low-level
interrupt handling/APIC programming.

- Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/