Re: [PATCH] ppc32 use simplified mmenonics

From: Benjamin Herrenschmidt
Date: Sat Aug 21 2004 - 21:14:52 EST


On Sun, 2004-08-22 at 08:23, Vincent Hanquez wrote:
> Hi LKML and Benjamin,
>
> This patch substitutes complex rlwinm instruction to the simplied
> instruction clrrwi when possible.
>
> This has the same meaning as the ppc knows only about rlwinm; clrrwi
> is just a language simplification.
>
> basicly it's a : s/rlwinm R1,R2,0,0,31-N/clrrwi R1,R2,N/

Oh well.. I've got quite used to tweaking rlwinm directly but I suppose
it's more clear for others to go to clrrwi. I see no obvious problem
though I haven't double checked the bit counts, I suppose you got the
substraction right everywhere but you know... it's always on the trivial
things that we make the nasty mistakes ;)

I'll look again when I'm back (I'm away for the week-end)

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/