Re: [PATCH] notify_parent and ptrace cleanup

[OGAWA Hirofumi]

Roland McGrath <roland@xxxxxxxxxx> writes:

> +	spin_unlock_irq(&current->sighand->siglock);

This unlock is odd. lock is missing?

> +	read_lock(&tasklist_lock);
> +	do_notify_parent_cldstop(current, current->parent);
> +	read_unlock(&tasklist_lock);
> +	schedule();
> +
> +	/* We are back.  */
> +	current->last_siginfo = NULL;
> +}

->last_siginfo is racy. Please, really please don't extend it until
the race condition is fixed.

SIGCONT restart the stopped task. Any lock doesn't prevent it.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/