Re: [PATCH] add PCI ROMs to sysfs

[Martin Mares]

Hello!

> I haven't received any comments on pci-sysfs-rom-17.patch. Is everyone
> asleep or is it ready to be pushed upstream? I'm still not sure that
> anyone has tried it on a ppc machine.

I was away, so sorry for the delay.  The patch looks OK to me now.

I was thinking again about the VGA ROM's and I tend to believe that even if
you happen to guess correctly where is the ROM shadowed, it would be better
to show the _original_ ROM image and deliver the shadow copy as a separate
file. (If somebody decides to initialize the VGA manually by running the
code in the ROM, is the shadow copy any better?)

I think that we can apply the current version of the patch (maybe except the
shadowing logic) and think about these issues later.

				Have a nice fortnight
-- 
Martin `MJ' Mares   <mj@xxxxxx>   http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"In theory, practice and theory are the same, but in practice they are different." -- Larry McVoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/