Re: Coding style: do_this(a,b) vs. do_this(a, b)

[Pavel Machek]

Hi!

> > Coding style document is not consistent with
> > itself on whether there should be space after
> > ","... This makes it standartize on ", " option.
> 
> You can read it both ways, right? It's easy.
> I can't even see the difference unless I'm
> looking for it.

Well, you maybe can't tell the difference, but I definitely can. You
can read code aligned by two spaces, right?

> We don't need any more bureaucracy.
> 
> do_this(a,b); (1)
> do_this(a, b); (2)
> do_this (a,b);

This looks extremely bad.

> do_this (a, b);
> 
> I can read them all. I might notice the space in
> front of the '(', but I might not. Even putting a
> space in front of the ';' isn't unreadable.
> 
> People will pass laws until they are choked off,
> unable to move without being in violation of some
> silly little thing.

I've seen people "fixing" code from (2) to (1), because they thought I
prefer (1). (And I definitely don't). So yes, it is important.

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/