Re: [PATCH][linux-usb-devel] Early USB handoff

From: Alan Stern
Date: Tue Aug 17 2004 - 09:13:43 EST


On Mon, 16 Aug 2004, Aleksey Gorelov wrote:

> >> Here is slightly improved early USB legacy handoff patch for 2.4.27
> >
> >The usual caveat is how we all wait for this to go into 2.6.
>
> Attached is a patch for 2.6.8.1

You could reorder and simplify slightly the code for handing off a UHCI
controller. It's safer to disable PIRQD, SMI#, and legacy support first
and then turn off the interrupt enable bits, all before stopping the
controller. You could even reset the controller rather than just stopping
it (although you might also want to avoid the 60ms delay this requires).
Take a look at reset_hc() in drivers/usb/host/uhci-hcd.c and see what you
think.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/