Re: [patch] Latency Tracer, voluntary-preempt-2.6.8-rc4-O6
From: Paulo Marques
Date: Tue Aug 17 2004 - 07:22:10 EST
Keith Owens wrote:
On Sat, 14 Aug 2004 05:50:50 +0100,
Paulo Marques <pmarques@xxxxxxxxxxxx> wrote:
Well, I found some time and decided to give it a go :)
This patch regresses some recent changes to kallsyms which handle
aliased symbols, IOW symbols with the same address. The speed up is
very good, but it has two problems with repeated addresses.
Hi,
I've been messing with scripts/kallsyms.c to try to follow Andi Kleen's
suggestion of calculating the markers at compile time. This would make
the code in kernel/kallsyms.c much simpler.
In the process I could get rid of the aliased symbols at compile time
also. There are only 2 places where they might matter:
- the kallsyms_lookup_name function. GREP'ing through the code shows
that this function is only used in arch/ppc64/xmon/xmon.c. Does xmon
need to know about aliased symbols?
- /proc/kallsyms. Of course this is a problem, because since this is
available in user space we can break applications that rely on having
aliased symbols there. Are there any?
I have no problem in keeping the aliased symbols as the code to handle
them is not that big anyway. Is just that it hurts my programmer
instincts to leave completely useless code hanging around. If it is not
completely useless, then it's another story :)
Any comments will be greatly appreciated,
--
Paulo Marques - www.grupopie.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/