[patch] allow netpoll_poll to be called recursively

[Jeff Moyer]

Hi, Matt,

This should fix the recursive netpoll_poll deadlock that can happen with
the newly introduced netpoll_poll_lock.

Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

--- linux-2.6.7/net/core/netpoll.c.getcpu	2004-08-16 15:50:47.275980584 -0400
+++ linux-2.6.7/net/core/netpoll.c	2004-08-16 15:46:53.328546000 -0400
@@ -72,7 +72,9 @@ void netpoll_poll(struct netpoll *np)
 	 * timeouts.  Thus, we set our budget to a more reasonable value.
 	 */
 	int budget = 16;
+	static int poll_owner = -1;
 	unsigned long flags;
+	int netpoll_rx_flag = NETPOLL_RX_DROP;
 
 	if(!np->dev || !netif_running(np->dev) || !np->dev->poll_controller)
 		return;
@@ -81,17 +83,27 @@ void netpoll_poll(struct netpoll *np)
 	np->dev->poll_controller(np->dev);
 
 	/* If scheduling is stopped, tickle NAPI bits */
-	spin_lock_irqsave(&netpoll_poll_lock, flags);
+	local_irq_save(flags);
+	if (!spin_trylock(&netpoll_poll_lock)) {
+		/* allow recursive calls on this cpu */
+		if (smp_processor_id() != poll_owner)
+			spin_lock(&netpoll_poll_lock);
+		else
+			netpoll_rx_flag = 0;
+	}
+	poll_owner = smp_processor_id();
+
 	if (np->dev->poll &&
 	    test_bit(__LINK_STATE_RX_SCHED, &np->dev->state)) {
-		np->dev->netpoll_rx |= NETPOLL_RX_DROP;
+		np->dev->netpoll_rx |= netpoll_rx_flag;
 		atomic_inc(&trapped);
 
 		np->dev->poll(np->dev, &budget);
 
 		atomic_dec(&trapped);
-		np->dev->netpoll_rx &= ~NETPOLL_RX_DROP;
+		np->dev->netpoll_rx &= ~netpoll_rx_flag;
 	}
+	poll_owner = -1;
 	spin_unlock_irqrestore(&netpoll_poll_lock, flags);
 
 	zap_completion_queue();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/