Re: menuconfig displays dependencies [Was: select FW_LOADER -> depends HOTPLUG]

[Russell King]

On Mon, Aug 16, 2004 at 09:57:33PM +0200, Adrian Bunk wrote:
> On Mon, Aug 16, 2004 at 12:47:05AM +0200, Roman Zippel wrote:
> > The use of select is already a crotch here, so there's no real correct 
> > handling. There are a few possibilities:
> > - if you select FW_LOADER, you have to select HOTPLUG too
> > - if you select FW_LOADER, you have to depend on HOTPLUG
> > - FW_LOADER itself can select HOTPLUG
> 
> Solution 2 is what my patch tried.
> 
> Thinking about them, I'd prefer solution 3. But with solution 1 or 3, 
> I'm sure people like Russell King will scream since this will make it 
> non-trivial to de-select HOTPLUG.

Let me make my position over the use of "select" clear: I do not
oppose its appropriate use, where that is defined as selecting
another configuration option for which the user has no visibility.

In the above case, it _may_ make sense (I haven't looked deeply
into it yet) to:

- make _all_ drivers which need FW_LOADER select it
- make _all_ drivers which currently depend on HOTPLUG select it
- make FW_LOADER select HOTPLUG
- remove user questions for FW_LOADER and HOTPLUG

That means that FW_LOADER and HOTPLUG are automatically selected
whenever the configuration requires them and are automatically
deselected when it doesn't need them, and you don't have to worry
about whether you can disable them now or after finding the
thousand and one configuration symbols which need to be turned off
first.

However, keeping the option user-visible _and_ using select is
problematical to say the least.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/