Re: [patch] fix netconsole hang with alt-sysrq-t

From: Jeff Moyer
Date: Mon Aug 16 2004 - 13:47:22 EST


==> Regarding Re: [patch] fix netconsole hang with alt-sysrq-t; Matt Mackall <mpm@xxxxxxxxxxx> adds:

mpm> On Thu, Aug 12, 2004 at 05:01:18PM -0400, Jeff Moyer wrote:
>> ==> Regarding Re: [patch] fix netconsole hang with alt-sysrq-t; Matt
>> Mackall <mpm@xxxxxxxxxxx> adds:
>>
mpm> On Fri, Aug 06, 2004 at 04:01:35PM -0400, Jeff Moyer wrote:
>> >> ==> Regarding Re: [patch] fix netconsole hang with alt-sysrq-t; Matt
>> >> Mackall <mpm@xxxxxxxxxxx> adds:
>> >>
mpm> On Fri, Aug 06, 2004 at 03:29:27PM -0400, Jeff Moyer wrote:
>> >> >> Hi, Matt,
>> >> >>
>> >> >> Here's the patch. Sorry it took me so long, been busy with other
>> >> work. >> Two things which need perhaps more thinking, can
>> netpoll_poll >> be called >> recursively (it didn't look like it to me)
>> >>
mpm> It can if the poll function does a printk or the like and wants to
mpm> recurse via netconsole. We could short-circuit that with an in_netpoll
mpm> flag, but let's worry about that separately.

mpm> We've got about 5 different issues in this thread/patch, and they need
mpm> to be broken up. I was going to do this, but I'm moving to another
mpm> city in 4 days. Jeff, if you'd be so kind (otherwise I'll get to it in
mpm> about a week and a half):

I'm all for splitting out patches. However, I think this is a bit too fine
grained. I'll separate out what makes sense to me. If you want it split
out further, let me know and I'll see what I can do. I'll send out the
patches in a short while.

-Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/