Re: [PATCH][2.4.27] PowerPC 745x data corruption bug fix

[Adrian Cox]

On Mon, 2004-08-16 at 03:54, Mikael Pettersson wrote:
> On Mon, 16 Aug 2004 08:13:59 +1000, Paul Mackerras wrote:

> >Does CONFIG_MPC10X_BRIDGE mean just MPC107, or is it set for (e.g.)
> >systems with a MPC106 as well?
> 
> I just copied this part from 2.6.8. Currently it
> seems CONFIG_MPC10X_BRIDGE is set for some platforms
> (sandpoint and lopec), but it is definitely not set
> for MPC106 machines like my beige PowerMac G3.

I don't understand how your patch can improve the stability of your
machine when CONFIG_MPC10X_BRIDGE isn't set. 

Pages should be marked coherent for the MPC106 as well as the MPC107,
but the problem shouldn't be seen unless the processor supports the
shared cache line state. My original patch only set
CPU_FTR_NEED_COHERENT for the 745x family, as only 745x plus 604 have
the shared state, but Tom Rini extended it to cover all the other
processors. I'm not convinced that extending it was necessary, but the
performance impact should be low.

Also, are you sure that you have an MPC106 together with a 7455
processor?  I thought that the 7455 required a revision D or later
MPC107.

- Adrian Cox
Humboldt Solutions Ltd.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/