Re: [PATCH] pcmcia driver model support [4/5]

[Russell King]

On Thu, Aug 05, 2004 at 10:28:20PM +0000, Adam Belay wrote:
> It is not safe to use the skt_sem in pcmcia_validate_mem.  This patch
> fixes a real world bug, and without it many systems will fail to shutdown
> properly.

However, we need to take this semaphore here to prevent the socket state
changing.  It sounds from your description that we're hitting yet another
stupid recursion bug in PCMCIA...

It sounds like we shouldn't be holding skt_sem when we wait for userspace
to reply to the ejection request.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/