Re: [PATCH] Fix x86_64 build of mmconfig.c

[Andi Kleen]

On Thu, 5 Aug 2004 22:54:01 +0200
Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

> On Thu, Aug 05, 2004 at 10:32:05PM +0200, Andi Kleen wrote:
> > On Thu, 05 Aug 2004 10:48:16 -0700
> > Tom Duffy <tduffy@xxxxxxx> wrote:
> > 
> > > Signed-by: Tom Duffy <tduffy@xxxxxxx>
> > > 
> > >   gcc -Wp,-MD,arch/x86_64/pci/.mmconfig.o.d -nostdinc -iwithprefix include -D__KERNEL__ -Iinclude -Iinclude2 -I/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/include -I/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/arch/x86_64/pci -Iarch/x86_64/pci -Wall -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -mno-red-zone -mcmodel=kernel -pipe -fno-reorder-blocks -Wno-sign-compare -fno-asynchronous-unwind-tables -O2 -fomit-frame-pointer -Wdeclaration-after-statement -I/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/ -I arch/i386/pci  -DKBUILD_BASENAME=mmconfig -DKBUILD_MODNAME=mmconfig -c -o arch/x86_64/pci/mmconfig.o /build1/tduffy/openib-work/linux-2.6.8-rc3-openib/arch/x86_64/pci/mmconfig.c
> > > /build1/tduffy/openib-work/linux-2.6.8-rc3-openib/arch/x86_64/pci/mmconfig.c:10:17: pci.h: No such file or directory
> > > 
> > > --- arch/x86_64/pci/Makefile.orig	2004-08-05 09:54:24.932007000 -0700
> > > +++ arch/x86_64/pci/Makefile	2004-08-05 09:53:53.171006000 -0700
> > > @@ -3,7 +3,7 @@
> > >  #
> > >  # Reuse the i386 PCI subsystem
> > >  #
> > > -CFLAGS += -I arch/i386/pci
> > > +CFLAGS += -Iarch/i386/pci
> > 
> > It never failed this way for me in hundreds of builds. Why is it failing for you? 
> > What gcc version do you use? 
> > 
> > Normally -Ifoo and -I foo should be really equivalent.
> 
> Notice the originally poster uses the make O=dir syntax - visible from the include2
> directory being present on the commandline.
> 
> This issue is kbuild related. When using 'make O=dir' syntax kbuild process
> options passed to gcc, and all -Isomething are processed.

[...]

Thanks for the explanation, Sam. I don't use O=, so this would explain it.
I added the change for now.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/