Re: block layer sg, bsg

From: Jens Axboe
Date: Wed Aug 04 2004 - 10:51:33 EST


On Wed, Aug 04 2004, David S. Miller wrote:
> On Wed, 4 Aug 2004 17:04:04 +0200
> Jens Axboe <axboe@xxxxxxx> wrote:
>
> > On Wed, Aug 04 2004, David S. Miller wrote:
> > >
> > > When you pass data structures in via {read,write}{,v}() system calls,
> > > you make it next to impossible for the CONFIG_COMPAT layer to cope
> > > with this.
> > >
> > > Please consider another way to pass in those sg_io_* things.
> >
> > Any suggestions?
>
> ioctl() :-(

ioctls suck :-)

> Or use a more portable well-defined type which does not change
> size nor layout between 32-bit and 64-bit environments.

Yeah that's what I thought you meant... Problem is, to stay compatible
with sg v3 I cannot do much about the structure. It should have been
designed with this in mind from the beginning.

But I can certainly draft a new structure that works...

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/