Re: [patch] mlock-as-nonroot revisted

[Rik van Riel]

On Wed, 4 Aug 2004, Andrea Arcangeli wrote:
> On Tue, Aug 03, 2004 at 09:21:34PM -0400, Rik van Riel wrote:
> > This is exactly why named hugetlb files are NOT included
> > in this accounting, only the ones created through the SHM
> > interface are.
> 
> but you're allowing everybody to alloc all RAM in hugetlb files with
> the change in the previos patch posted by Arjan

Nope, Arjan's patch (and my incremental) touch hugetlb_zero_setup,
which only seems to be called from ipc/shm.c

Normal hugetlb file creation (through the filesystem) isn't touched
by these patches.

> (you're currently posted incremental patches against Arjan's patch at
> the top of the thread I hope), so you must definitely apply "this"
> accounting to hugetlb files too or it's still insecure as far as I can
> tell.

The patch only touches "anonymous" hugetlb files, ie. the ones
created through ipc/shm.c.  I'm not sure why you claim that the
others would be affected by this patch...

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/