Re: [PATCH 3/5] Free sysfs_dirent on file removal

From: viro
Date: Tue Aug 03 2004 - 07:55:49 EST


On Thu, Jul 29, 2004 at 03:40:31PM -0500, Maneesh Soni wrote:
>
>
> o The following patch implements the code to free up the sysfs_dirents upon
> directory or file removal. It uses the sysfs_dirent based tree in order
> to remove the directory contents before removing the directory itself.
> It could do this without taking dcache_lock in sysfs_remove_dir() as
> it doesnot use dentry based tree.

ACK, but some of that (freeing sysfs_dirent upon removal, no smarts, just
enough to plug the leak) belongs in the first chunk.

Note that there we shouldn't care about refcounts - that stuff belongs here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/