Re: [PATCH] fix gcc 3.4 inlining errors in drivers/scsi/dc395x.c

[Jesper Juhl]

On Sun, 1 Aug 2004, Adrian Bunk wrote:

> On Sun, Aug 01, 2004 at 02:02:50PM +0200, Jesper Juhl wrote:
> > 
> > drivers/scsi/dc395x.c fails to build in 2.6.8-rc2-mm1 with gcc 3.4.0 with 
> > the following errors :
> > 
> > drivers/scsi/dc395x.c: In function `dc395x_handle_interrupt':
> > drivers/scsi/dc395x.c:388: sorry, unimplemented: inlining failed in call to 'enable_msgout_abort': function body not available
> > drivers/scsi/dc395x.c:1740: sorry, unimplemented: called from here
> > 
> > drivers/scsi/dc395x.c: In function `msgin_set_async':
> > drivers/scsi/dc395x.c:394: sorry, unimplemented: inlining failed in call to 'set_xfer_rate': function body not available
> > drivers/scsi/dc395x.c:2677: sorry, unimplemented: called from here
> > 
> > The patch below fixes the build by un-inlining the functions (an 
> > alternative would be to rework the file so the functions move before their 
> > first use). As for 'set_xfer_rate' the function itself was not declared 
> > inline, only the prototype.
> >...
> 
> Jamie Lenehan already ACK'ed a similar patch I sent two weeks ago which 
> moves enable_msgout_abort instead of un-inlining it.
> 
Ohh, OK, I did a search in my lkml mailbox before sending off the patch, 
guess I missed it.

Since you already did a bunch of these I'm trying to avoid sending patches 
for the ones you alrady did, but a few might slip. Just trying to fill in 
the remaining blanks :)


> Both approaches are feasible, it's up to the maintainers to decide which 
> one is better in this case.
> 
Agreed.


/Jesper

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/