Re: [PATCH] use for_each_cpu

From: Anton Blanchard
Date: Sun Aug 01 2004 - 02:37:07 EST



> > The per cpu schedule counters need to be summed up over all possible cpus.
> > When testing hotplug cpu remove I saw the sum of the online cpu count
> > for nr_uninterruptible go negative which made the load average go nuts.
>
> I think the preferred approach here is to transfer the count over to the
> current CPU in the CPU_DEAD handler.

They only look to be called out of proc, and once every 5 seconds for
loadaverage calculations. Is it worth adding complexity to the cpu
notifiers vs just using for_each_cpu?

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/