Re: PATCH: VLAN support for 3c59x/3c90x

From: Willy Tarreau
Date: Sat Jul 31 2004 - 11:22:18 EST


On Sat, Jul 31, 2004 at 12:05:03PM -0400, Jeff Garzik wrote:
> >Ok, sorry, I've just checked, they are 6. But I incidentely used the
> >feature
> >on 2 of them (dl2k and starfire). But more drivers still have the
> >'static int mtu=1500' preceeded by a comment stating "allow the user to
> >change
> >the mtu". Why is it not a #define then, if nobody can change it anymore ?
>
> People can change it all the time with ifconfig.

no, they change dev->mtu, not the 'static' mtu. I think it has been
inherited from the old days without MODULE_PARM.

> >Jeff, do you know the absolute hardware limit on the tulip ? I've seen
> >the
>
> It depends on the tulip.
>
> Look at Donald Becker's tulip.c for reference, it has full ->change_mtu
> support (as does 3c59x.c I believe).

ok thanks, I'll look at this.

Regards,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/