Re: [PATCH] Drop ISA dependencies from IRDA drivers
From: Andi Kleen
Date: Fri Jul 16 2004 - 00:47:03 EST
On Fri, Jul 16, 2004 at 12:32:44AM +0200, Martin Diehl wrote:
> On 15 Jul 2004, Andi Kleen wrote:
> > Remove wrong ISA dependencies for IRDA drivers.
> > diff -u linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig
> > --- linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o 2004-07-12 06:09:05.000000000 +0200
> > +++ linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig 2004-07-15 18:33:48.000000000 +0200
> > @@ -310,7 +310,7 @@
> > config NSC_FIR
> > tristate "NSC PC87108/PC87338"
> > - depends on IRDA && ISA
> > + depends on IRDA
> Admittedly I haven't tried either, but I'm pretty sure this patch will
> break building those drivers because they are calling irda_setup_dma -
> which is CONFIG_ISA. Maybe this can be dropped but I don't see what's
> wrong with !64BIT instead.
Hmm, good point.
!64BIT is not needed - apparently they are 64bit clean.
The reason I want to drop the CONFIG_ISA depency is that they *should*
be built on x86-64 too.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/