Re: [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?)]
From: Greg KH
Date: Thu Jul 01 2004 - 15:42:11 EST
On Thu, Jul 01, 2004 at 03:31:17PM -0500, linas@xxxxxxxxxxxxxx wrote:
> + /* Log the error in the unlikely case that there was one. */
> + if (unlikely(logit)) {
> + buff_copy = kmalloc (RTAS_ERROR_LOG_MAX, GFP_ATOMIC);
> + if (buff_copy) {
> + memcpy (buff_copy, rtas_err_buf, RTAS_ERROR_LOG_MAX);
> + }
> + }
> +
The extra space before the '(' isn't needed, as the rest of this file
shows...
And shouldn't you return -ENOMEM if you are out of memory, and can't log
the message?
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/