[PATCH] retry force umount (was Re: NFS and umount -f)

[Daniel McNeil]

On Tue, 2004-06-08 at 08:59, Trond Myklebust wrote:
> PÃ ty , 08/06/2004 klokka 11:54, skreiv Andy:
> > Why does this NOT do what is should be doing, i.e. umount no matter what?
> > 
> > Sometimes I get 
> > 
> > umount2 : Stale NFS file handle
> > umount : machine/path: Illegal seek
> > 
> > and it does not umount it.
> > 
> > What part of
> >  -f "Force unmount (in case of unreachable NFS system)" (umount man page)
> > 
> > does linux not understand?
> 
> Works for me...
> 

This works for me on 2.6.7 as well.  However, I would get EBUSY back
if processes were hung doing nfs operations to the downed server.
The processes would get unstuck and get EIO, but the umount would
still fail.  Doing a 2nd umount -f with no processes waiting for
the server would succeed.  This patch retries force umounts in
the kernel an extra time after giving them time to wake up and
get out of the kernel.  It doesn't seem quite right to fail
a bunch of nfs operations and leave the file system mounted.

Daniel

diff -urp linux-2.6.7.orig/fs/namespace.c linux-2.6.7/fs/namespace.c
--- linux-2.6.7.orig/fs/namespace.c	2004-06-22 16:41:15.000000000 -0700
+++ linux-2.6.7/fs/namespace.c	2004-06-23 16:28:12.986370695 -0700
@@ -363,6 +363,7 @@ static int do_umount(struct vfsmount *mn
 {
 	struct super_block * sb = mnt->mnt_sb;
 	int retval;
+	int force_retry_count = 1;
 
 	retval = security_sb_umount(mnt, flags);
 	if (retval)
@@ -376,8 +377,11 @@ static int do_umount(struct vfsmount *mn
 	 * might fail to complete on the first run through as other tasks
 	 * must return, and the like. Thats for the mount program to worry
 	 * about for the moment.
+	 * Retry FORCE umount to give processes a chance to wakeup
+	 * and get out of the file system.
 	 */
 
+retry_force_umount:
 	lock_kernel();
 	if( (flags&MNT_FORCE) && sb->s_op->umount_begin)
 		sb->s_op->umount_begin(sb);
@@ -427,6 +431,18 @@ static int do_umount(struct vfsmount *mn
 		retval = 0;
 	}
 	spin_unlock(&vfsmount_lock);
+
+	if (flags & MNT_FORCE && retval && force_retry_count-- > 0) {
+		up_write(&current->namespace->sem);
+		/*
+		 * give processes a chance to wakeup from force umount
+		 */
+		set_current_state(TASK_UNINTERRUPTIBLE);
+		schedule_timeout(10);
+		goto retry_force_umount;
+		
+	}
+
 	if (retval)
 		security_sb_umount_busy(mnt);
 	up_write(&current->namespace->sem);



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/