Re: [PATCH 2.6.7-mm1] MBR centralization

[FabF]

On Wed, 2004-06-23 at 23:06, Andrew Morton wrote:
> FabF <fabian.frederick@xxxxxxxxx> wrote:
> >
> > +/*Master boot record magic numbers*/
> > +#define MSDOS_MBR_SIGNATURE 0xaa55
> > +#define MSDOS_MBR(p) le16_to_cpu((u16)*p) == MSDOS_MBR_SIGNATURE
> 
> I'd make this
> 
> /*
>  * Check for MSDOS Master Boot Record signature
>  */
> static inline int msdos_mbr(u16 v)
> {
> 	return le16_to_cpu(v) == 0xaa55;
> }
That means I would have to cast from all msdos_partition calls 
e.g. msdos_mbr((u16)*(data+510)) .Is this the right way ?

Regards,
FabF

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/