Re: [PATCH] Driver Core patches for 2.6.7

[Greg KH]

On Tue, Jun 22, 2004 at 06:21:01PM -0500, Dmitry Torokhov wrote:
> On Tuesday 22 June 2004 12:41 pm, Greg KH wrote:
> 
> >  
> >  void class_unregister(struct class * cls)
> >  {
> >  	pr_debug("device class '%s': unregistering\n",cls->name);
> > +	remove_class_attrs(cls);
> >  	subsystem_unregister(&cls->subsys);
> >  }
> >  
> 
> Question: is it necessary to call remove_class_attrs? I thought that sysfs
> automatically destroys all children when parent is destroyed? Am I imagining
> things?

No, you aren't imagining things.  But it's considered "good form" to
remove them if you can, as this will probably change in 2.7, and it will
make my life easier trying to audit the whole tree at that time...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/