Re: [PATCH] missing NULL check in drivers/char/n_tty.c

From: Paul Fulghum
Date: Mon Jun 21 2004 - 18:59:03 EST


Dan Aloni wrote:

Apropos cleanups in the tty subsystem, what is the purpose of all the *_paranoia_check() calls that almost every driver duplicates for itself? Perhaps this can be removed.

At some time in the distant past, it must have been a brute force
attempt to debug some *serious* problems. I've never had the
need to enable those checks in the last 6 years.

I agree with your thought, and will be removing them from at
least the synclinkxx drivers. The checks clutter the code
with little gain. And cruft like that keeps propogating to new drivers.

--
Paul Fulghum
paulkf@xxxxxxxxxxxxx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/