Re: [PATCH 1/4]Diskdump Update

[Arjan van de Ven]

On Mon, Jun 21, 2004 at 04:59:52PM +0900, Takao Indoh wrote:
> Hi,
> 
> Now I am fixing diskdump according to comments by you and Christoph.
> 
> On Fri, 11 Jun 2004 13:50:45 +0200, Arjan van de Ven wrote:
> 
> >> +#ifdef CONFIG_PROC_FS
> >> +static int proc_ioctl(struct inode *inode, struct file *file, unsigned 
> >> int cmd, unsigned long param)
> >
> >
> >ehhh this looks evil
> 
> Do you mean I should use not ioctl but the following style?
> 
> echo "add /dev/hda1" > /proc/diskdump
> echo "delete /dev/hda1" > /proc/diskdump

well no since /dev/hda is pointless; major/minor pairs maybe.
But why in /proc???? it sounds like a sysfs job to me, where you probably
want to represent a dump relationship with a symlink, and use "rm" to remove
an entry..

Attachment: pgp00000.pgp
Description: PGP signature