Re: [PATCH] PPC64 iSeries viodasd proc file

From: Christoph Hellwig
Date: Fri Jun 18 2004 - 10:27:57 EST


On Fri, Jun 18, 2004 at 11:09:40AM -0400, Jeff Garzik wrote:
> Stephen Rothwell wrote:
> >Hi Andrew,
> >
> >This patch adds a proc file for viodasd so to make it
> >easier to enumerate the available disks. It is in a
> >(somewhat) strange format to try for a simple level of
> >compatability with the old viodasd code (that was in a
> >couple of vendor's kernels).
>
> Exporting redundant information from procfs is a step backwards, since
> we have sysfs.
>
> I would prefer not to apply this. Upstream is for 'getting it right',
> not for dragging every little vendor kernel hack along.

Agreed. And the old viodasd reason was rejected exactly because it was
such a f***ing mess.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/