Re: Subject: Re: make checkstack on m68k

[Geert Uytterhoeven]

On Thu, 17 Jun 2004, [iso-8859-1] Jörn Engel wrote:
> On Thu, 17 June 2004 18:43:18 +1000, Finn Thain wrote:
> > Jörn Engel wrote:
> > > On Wed, 16 June 2004 18:51:03 +0200, Geert Uytterhoeven wrote:
> > > >
> > > > @@ -40,6 +40,11 @@
> > > >  	} elsif ($arch =~ /^ia64$/) {
> > > >  		#e0000000044011fc:       01 0f fc 8c     adds r12=-384,r12
> > > >  		$re = qr/.*adds.*r12=-(([0-9]{2}|[3-9])[0-9]{2}),r12/o;
> > > > +	} elsif ($arch =~ /^m68k$/) {
> > > > +		#2b6c:       4e56 fb70       linkw %fp,#-1168
> > > > +		#$re = qr/.*linkw %fp,#-([0-9]{1,4})/o;
> > > > +		#1df770:       defc ffe4       addaw #-28,%sp
> > > > +		$re = qr/.*addaw #-([0-9]{1,4}),%sp/o;
> > >
> > > For i386 I used a really ugly hack, but this needs someone with better
> > > perl skills.  Matt, can you find a nice regex?  If it adds more
> > > brackets, that's fine.  We'll just add empty brackets to the other
> > > regexes and use $2 instead of $1 or so.
> >
> > There is no nice way to do this in perl in a single regex and have the
> > result always in $1 or always in $2. So you would test for undef in one
> > and use the other.  But then the other arch regexes that capture more than
> > one cluster would need to be rewritten to use (?: ) syntax to get
> > clustering without capturing (see man perlre) so as to leave $2 undefined.
> >
> > A list of regexes for each arch would be nice. But should probably be
> > left until needed. Following is probably the simplest way. The regexes
> > remain understandable to mortals since they don't do fancy stuff. And the
> > other archs don't need to be touched.
>
> It's not as ugly as my hack.  Can I get a success report from m68k?
> Thanks!

Works.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/