Re: PATCH: Further aacraid work

From: Arjan van de Ven
Date: Thu Jun 17 2004 - 10:17:08 EST


On Thu, 2004-06-17 at 16:58, Alan Cox wrote:
> On Thu, Jun 17, 2004 at 09:55:03AM -0500, James Bottomley wrote:
> > This is hardly a big problem, is it? it only occurs during the first
> > few moments of system operation. After that, the pages assigned to a
> > virtual region are pretty much random.
>
> When I looked at it (which I grant was 2.2 and 2.4 the pattern was
> visible on machines that had been running for a week or more)

probably because of the buddy grouping/ungrouping;

--- linux-2.6.7/mm/page_alloc.c~ 2004-06-17 17:13:58.830727762
+0200
+++ linux-2.6.7/mm/page_alloc.c 2004-06-17 17:13:58.831727642 +0200
@@ -301,7 +301,7 @@ expand(struct zone *zone, struct page *p
area--;
high--;
size >>= 1;
- list_add(&page->lru, &area->free_list);
+ list_add_tail(&page->lru, &area->free_list);
MARK_USED(index, high, area);
index += size;
page += size;

Attachment: signature.asc
Description: This is a digitally signed message part