rwsem-spinlock error (was: Re: Linux 2.4.27-pre6)

From: Geert Uytterhoeven
Date: Thu Jun 17 2004 - 05:14:11 EST


On Wed, 16 Jun 2004, Marcelo Tosatti wrote:
> <nickpiggin:yahoo.com.au>:
> o rwsem race fixes backported from 2.6

> Nuno Monteiro:
> o Fix rwsem-fix typo
> o Complete rwsem typo fix

| rwsem-spinlock.c: In function `__rwsem_wake_one_writer':
| rwsem-spinlock.c:111: `tsk' undeclared (first use in this function)
| rwsem-spinlock.c:111: (Each undeclared identifier is reported only once
| rwsem-spinlock.c:111: for each function it appears in.)

How can this ever compile on any architecture?

| static inline struct rw_semaphore *__rwsem_wake_one_writer(struct rw_semaphore *sem)
| {
| struct rwsem_waiter *waiter;
|
| sem->activity = -1;
|
| waiter = list_entry(sem->wait_list.next,struct rwsem_waiter,list);
| list_del(&waiter->list);
|
| tsk = waiter->task;
| mb();
| waiter->task = NULL;
| wake_up_process(tsk);
| free_task_struct(tsk);
| return sem;
| }

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/